Change default file extention#153
Conversation
Changed txt to md because it's markdown note, it's useful because we can, after download the note, or on windows client or whatever edit the notes with appropriated software tested on nextcloud 12
|
The second thing that irritated me about this app was exactly this...looking forward to seeing this merged and released. |
|
@Henni, @LukasReschke — can you please merge this PR? It would be nice to open notes directly from another app (MarkDown App) later :) |
|
Guys, please merge. I'd like to get rid of the annoying "code integrity check" error. |
|
Tested with NC13 and 14 no issues found. |
korelstar
left a comment
korelstar
left a comment
There was a problem hiding this comment.
Thanks for this PR @lefuturiste! It would be nice if you could enhance it by introducing a setting for the file extension as it was discussed in #24. The settings should be accessible from the bottom of the app-navigation like in the files app. Thanks!
There was a problem hiding this comment.
Yep, as @korelstar said already. TL;DR we can’t make .md the default extension cause then any notes synced down to standard Windows will not be easy to open (keep in mind many people using Nextcloud have never heard of Markdown). It should only be .md if Markdown is used in the note, or if the »Default extension« setting (to be developed) is set from Plain text (.txt) to Markdown (.md).
jancborchardt
added
enhancement
|
Isn't the standard behavior on Windows for it to ask what program they wish to use and then allow defaulting that in the future? |
|
Hi all, the setting would be nice, but what about merging this and leave the settings-part to another PR? It looks like the PR author is probably not interested in doing this and the change of the default extension is therefore blocked. Thanks! |
|
The issue for this is called "Add setting" #24, and that's what we also really need in this case. Normally we do step-by-step developments, but here changing the default would break it for any Windows user who does not know what md files are. This is not something we can do, so the setting has to be there. Otherwise we would just swap from one issue to the next. Any code contribution or alternatively donation towards the issue on Bountysource is much appreciated! 🎉 |
|
Closed due to inactivity and in favor of #223, which will be finished in the next days. |
9 participants
Changed txt to md because it's markdown note, it's useful because we can, after download the note, or on windows client or whatever edit the notes with appropriated software
tested on nextcloud 12